Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go BLUI #20

Merged
merged 15 commits into from
Nov 10, 2021
Merged

Go BLUI #20

merged 15 commits into from
Nov 10, 2021

Conversation

emclaug2
Copy link
Contributor

@emclaug2 emclaug2 commented Nov 4, 2021

Changes proposed in this Pull Request:

  • Go BLUI

Needs to be tested.

@emclaug2 emclaug2 added the master For PRs going into the master branch label Nov 4, 2021
@emclaug2
Copy link
Contributor Author

emclaug2 commented Nov 8, 2021

This can be tested in the react-native-showcase-demo. Checkout this branch:
https://github.com/pxblue/react-native-showcase-demo/tree/feature/blui

Run yarn && yarn android | yarn ios

@emclaug2 emclaug2 requested a review from bkarambe November 9, 2021 13:57
@jeffvg
Copy link
Contributor

jeffvg commented Nov 9, 2021

This can be tested in the react-native-showcase-demo. Checkout this branch: https://github.com/pxblue/react-native-showcase-demo/tree/feature/blui

Run yarn && yarn android | yarn ios

should RN showcase demo feature/blui branch run with @brightlayer-ui/react-native-themes": "^6.0.0-beta.0" without any other changes? Right now I'm seeing issue with blui RN vector icons on android and iOS just crashing on me

@emclaug2
Copy link
Contributor Author

emclaug2 commented Nov 9, 2021

This can be tested in the react-native-showcase-demo. Checkout this branch: https://github.com/pxblue/react-native-showcase-demo/tree/feature/blui
Run yarn && yarn android | yarn ios

should RN showcase demo feature/blui branch run with @brightlayer-ui/react-native-themes": "^6.0.0-beta.0" without any other changes? Right now I'm seeing issue with blui RN vector icons on android and iOS just crashing on me

Are you cloning the showcase repo? The git pointers won't work until we change the org name.

@daileytj
Copy link
Contributor

daileytj commented Nov 9, 2021

I'm having trouble getting the showcase running on iOS. It's spinning up just fine in the terminal but never installs the app on the simulator. I'm just going to spin up another project to test this, but it would be ideal if the showcase was installed. Not sure what's happening there though ¯_(ツ)_/¯

@daileytj daileytj merged commit 9c81327 into master Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
master For PRs going into the master branch
Development

Successfully merging this pull request may close these issues.

6 participants