Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update packages to ~latest #35

Merged
merged 12 commits into from
Dec 1, 2020
Merged

Update packages to ~latest #35

merged 12 commits into from
Dec 1, 2020

Conversation

joebochill
Copy link
Collaborator

Update lots of packages to latest (typescript, react native, components, react native paper)

Changes proposed in this Pull Request:

  • Updates packages
  • Re-lint

NOTE: There is an issue in the ViewPager component that is causing problems (opening the deep link debug link for invite register will crash the app). This PR downgrades the dependency to 3.x to fix that error, but I don't think that is a good solution long term since we were previously depending on version 4.x.

@joebochill
Copy link
Collaborator Author

I narrowed to bug down to a specific version of react-native-viewpager. I put us back on 4.0.1 (the last working version) and updated the readme instructions to include that specific version.

Everything should be working smoothly now.

For reference: callstack/react-native-pager-view#167

@joebochill joebochill mentioned this pull request Nov 30, 2020
Closed
@joebochill joebochill linked an issue Nov 30, 2020 that may be closed by this pull request
iOS example app images not loading (iOS 14.1 Xcode 12) #32
Closed
@joebochill joebochill marked this pull request as ready for review November 30, 2020 18:05
@joebochill joebochill mentioned this pull request Nov 30, 2020
Closed
@joebochill joebochill changed the title Feature/remove ts ignore Update packages to ~latest Nov 30, 2020
@jeffvg
Copy link
Contributor

jeffvg commented Nov 30, 2020

looks like the EULA checkbox is missing in action again on android.

image

@joebochill
Copy link
Collaborator Author

looks like the EULA checkbox is missing in action again on android.

image

Is it missing in dev?

@joebochill
Copy link
Collaborator Author

looks like the EULA checkbox is missing in action again on android.

Is it missing in dev?

@joebochill
Copy link
Collaborator Author

looks like the EULA checkbox is missing in action again on android.

Is it missing in dev?

No it's not. I think something may have changed in RNVI from v6 to 7. There was a step in their setup instructions that we were missing on the Android side. For some reason the Material icons were working fine, but the Material Community ones are not (I guess the Android platform has material icons by default). Anyway, I added that extra config line in the gradle file and it looks like the checkboxes are working correctly now.

jeffvg
jeffvg approved these changes Dec 1, 2020
View reviewed changes
Copy link
Contributor

@jeffvg jeffvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no issues identified looks good on android and iOS

@joebochill joebochill merged commit 904a0b7 into dev Dec 1, 2020
@delete-merged-branch delete-merged-branch bot deleted the feature/remove-ts-ignore branch December 1, 2020 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffvg jeffvg jeffvg approved these changes

@daileytj daileytj Awaiting requested review from daileytj

@emclaug2 emclaug2 Awaiting requested review from emclaug2

@huayunh huayunh Awaiting requested review from huayunh

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

iOS example app images not loading (iOS 14.1 Xcode 12)
2 participants
@joebochill @jeffvg