Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/blui 5601 symbols GitHub ci #108

Merged
merged 12 commits into from
May 2, 2024
Merged

Feature/blui 5601 symbols GitHub ci #108

merged 12 commits into from
May 2, 2024

Conversation

JeffGreiner-eaton
Copy link
Collaborator

@JeffGreiner-eaton JeffGreiner-eaton commented Apr 29, 2024 •
edited
Loading

Fixes BLUI-5601# .

Changes proposed in this Pull Request:

  • add blui-ci github workflow
  • remove circleCI config and stop building
  • update readme with new badge
  • remove circleCI references from publish readme
  • add tagging job

Screenshots / Screen Recording (if applicable)

To Test:

Any specific feedback you are looking for?

@github-actions github-actions bot added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Apr 29, 2024
@JeffGreiner-eaton JeffGreiner-eaton changed the title Feature/blui 5602 symbols GitHub ci Feature/blui 5601 symbols GitHub ci Apr 29, 2024
@JeffGreiner-eaton JeffGreiner-eaton marked this pull request as ready for review April 30, 2024 14:26
surajeaton
surajeaton approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@surajeaton surajeaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@JeffGreiner-eaton JeffGreiner-eaton merged commit 7baa230 into dev May 2, 2024
4 checks passed
@JeffGreiner-eaton JeffGreiner-eaton deleted the feature/blui-5602-symbols-github-ci branch May 2, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surajeaton surajeaton surajeaton approved these changes

@joebochill joebochill Awaiting requested review from joebochill joebochill is a code owner

@manojleaton manojleaton Awaiting requested review from manojleaton

@ektaghag-eaton ektaghag-eaton Awaiting requested review from ektaghag-eaton ektaghag-eaton is a code owner

@ArshdeepSingh3-eaton ArshdeepSingh3-eaton Awaiting requested review from ArshdeepSingh3-eaton

@priyankakmEaton priyankakmEaton Awaiting requested review from priyankakmEaton

@huayunh huayunh Awaiting requested review from huayunh

Assignees
No one assigned
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JeffGreiner-eaton @surajeaton