Remove access to changing `TSDataset` attributes #630

DanilSmorchkov · 2025-03-11T20:19:22Z

Before submitting (must do checklist)

Did you read the contribution guide?
Did you update the docs? We use Numpy format for all the methods and classes.
Did you write any new necessary tests?
Did you update the CHANGELOG?

Proposed Changes

See #598

Closing issues

Closed #598

…level

github-actions · 2025-03-11T20:23:26Z

🚀 Deployed on https://deploy-preview-630--etna-docs.netlify.app

codecov · 2025-03-12T07:14:22Z

Codecov Report

Attention: Patch coverage is 92.89941% with 12 lines in your changes missing coverage. Please review.

Project coverage is 88.88%. Comparing base (5156e86) to head (5dfb9e8).

Files with missing lines	Patch %	Lines
etna/datasets/tsdataset.py	95.49%	5 Missing ⚠️
etna/analysis/utils.py	0.00%	4 Missing ⚠️
etna/analysis/forecast/plots.py	50.00%	1 Missing ⚠️
etna/analysis/forecast/utils.py	66.66%	1 Missing ⚠️
etna/models/mixins.py	66.66%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #630      +/-   ##
==========================================
- Coverage   90.50%   88.88%   -1.62%     
==========================================
  Files         259      259              
  Lines       18060    18072      +12     
==========================================
- Hits        16345    16064     -281     
- Misses       1715     2008     +293

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

review-notebook-app · 2025-03-12T07:51:08Z

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

CHANGELOG.md

d-a-bunin · 2025-03-12T14:24:58Z

etna/analysis/decomposition/plots.py

@@ -67,7 +67,7 @@ def plot_trend(
        segments = ts.segments

    _, ax = _prepare_axes(num_plots=len(segments), columns_num=columns_num, figsize=figsize)
-    df = ts.df
+    df = ts._df


We could probably replace it with smth like to_pandas() in the future. Now we avoid it because of additional copying but it could be not a problem in copy-on-write mode on new pandas.

etna/analysis/utils.py

etna/metrics/base.py

d-a-bunin · 2025-03-12T14:29:21Z

etna/metrics/base.py

@@ -271,8 +271,8 @@ def _validate_nans(self, y_true: TSDataset, y_pred: TSDataset):
        ValueError:
            If there are NaNs in ``y_true`` or ``y_pred``
        """
-        df_true = y_true.df.loc[:, pd.IndexSlice[:, "target"]]
-        df_pred = y_pred.df.loc[:, pd.IndexSlice[:, "target"]]
+        df_true = y_true._df.loc[:, pd.IndexSlice[:, "target"]]


We could probably replace it with to_pandas in the future.

tests/test_models/test_autoarima_model.py

tests/test_models/test_catboost.py

tests/test_models/test_sarimax_model.py

tests/test_transforms/test_encoders/test_categorical_transform.py

tests/test_transforms/test_math/test_sklearn_transform_interface.py

CHANGELOG.md

etna/datasets/tsdataset.py

review-notebook-app · 2025-03-13T07:05:46Z

View / edit / reply to this conversation on ReviewNB

d-a-bunin commented on 2025-03-13T07:05:46Z
----------------------------------------------------------------

Line #62.            horizon = len(ts.to_pandas())

Couldn't we use ts.size here?

etna/datasets/tsdataset.py

Danil Smorchkov added 16 commits March 11, 2025 13:21

create _df attribute

5a78a8f

change tests

02d9bc5

Merge remote-tracking branch 'origin/master' into issue-598

4d12e73

create _raw_df attribute

38a1e62

change tests

6c4167d

add _df_exog attribute

5148e79

change tests

f028871

create _known_feature attribute and read_only property known_future

4472279

change tests and add new ones

4bcc365

create _freq attribute and read_only property freq

f3218d5

add new test

da4d848

create _current_df_level attribute and property current_df_level

b35684f

add new test

5a45b19

create _current_df_exog_level attribute and property current_df_exog_…

434f873

…level

add new test

bb3d9bf

lint

e5a521d

DanilSmorchkov self-assigned this Mar 11, 2025

github-actions bot temporarily deployed to pull request March 11, 2025 20:23 Inactive

Danil Smorchkov added 2 commits March 12, 2025 09:10

fix some tests

e31c3b7

change changelog

b26bbf6

github-actions bot temporarily deployed to pull request March 12, 2025 06:37 Inactive

change notebooks

4f0606c

github-actions bot temporarily deployed to pull request March 12, 2025 07:55 Inactive

some fixes

d1fb936

github-actions bot temporarily deployed to pull request March 12, 2025 08:05 Inactive

change .columns to ._df.columns

a375969

github-actions bot temporarily deployed to pull request March 12, 2025 08:21 Inactive

lint

1ab14b4

github-actions bot temporarily deployed to pull request March 12, 2025 08:55 Inactive

fix typo

7298012

github-actions bot temporarily deployed to pull request March 12, 2025 09:06 Inactive

notebook view

36d9326

github-actions bot temporarily deployed to pull request March 12, 2025 09:12 Inactive

DanilSmorchkov requested a review from d-a-bunin March 12, 2025 10:16

d-a-bunin requested changes Mar 12, 2025

View reviewed changes

review fixed

c57c1b3

github-actions bot temporarily deployed to pull request March 12, 2025 20:03 Inactive

Danil Smorchkov added 2 commits March 12, 2025 23:08

review fixed v2

f3f94cc

fix typo in changelog

0d3ff73

github-actions bot temporarily deployed to pull request March 12, 2025 20:16 Inactive

review fixed v3

7c3efd3

github-actions bot temporarily deployed to pull request March 12, 2025 20:46 Inactive

review fixed v4

72d51e3

github-actions bot temporarily deployed to pull request March 13, 2025 06:37 Inactive

d-a-bunin reviewed Mar 13, 2025

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

etna/datasets/tsdataset.py Outdated Show resolved Hide resolved

review fixed v5

9aa9789

github-actions bot temporarily deployed to pull request March 13, 2025 07:56 Inactive

fix isnull docs

b24b65a

github-actions bot temporarily deployed to pull request March 13, 2025 10:23 Inactive

d-a-bunin reviewed Mar 13, 2025

View reviewed changes

etna/datasets/tsdataset.py Outdated Show resolved Hide resolved

Danil Smorchkov added 2 commits March 13, 2025 13:43

fix isnull docs

bd0de1f

fix isnull docs

5dfb9e8

github-actions bot temporarily deployed to pull request March 13, 2025 11:03 Inactive

d-a-bunin approved these changes Mar 13, 2025

View reviewed changes

DanilSmorchkov merged commit f05e030 into master Mar 13, 2025
14 checks passed

DanilSmorchkov deleted the issue-598 branch March 13, 2025 12:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove access to changing `TSDataset` attributes #630

Remove access to changing `TSDataset` attributes #630

DanilSmorchkov commented Mar 11, 2025 •

edited

Loading

github-actions bot commented Mar 11, 2025 •

edited

Loading

codecov bot commented Mar 12, 2025 •

edited

Loading

review-notebook-app bot commented Mar 12, 2025

d-a-bunin Mar 12, 2025

d-a-bunin Mar 12, 2025

review-notebook-app bot commented Mar 13, 2025 •

edited

Loading

Remove access to changing TSDataset attributes #630

Remove access to changing TSDataset attributes #630

Conversation

DanilSmorchkov commented Mar 11, 2025 • edited Loading

Before submitting (must do checklist)

Proposed Changes

Closing issues

github-actions bot commented Mar 11, 2025 • edited Loading

codecov bot commented Mar 12, 2025 • edited Loading

Codecov Report

review-notebook-app bot commented Mar 12, 2025

d-a-bunin Mar 12, 2025

Choose a reason for hiding this comment

d-a-bunin Mar 12, 2025

Choose a reason for hiding this comment

review-notebook-app bot commented Mar 13, 2025 • edited Loading

Remove access to changing `TSDataset` attributes #630

Remove access to changing `TSDataset` attributes #630

DanilSmorchkov commented Mar 11, 2025 •

edited

Loading

github-actions bot commented Mar 11, 2025 •

edited

Loading

codecov bot commented Mar 12, 2025 •

edited

Loading

review-notebook-app bot commented Mar 13, 2025 •

edited

Loading