Remove TSDataset.loc, TSDataset.columns
#631
Conversation
|
🚀 Deployed on https://deploy-preview-631--etna-docs.netlify.app |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #631 +/- ##
==========================================
- Coverage 90.51% 90.50% -0.01%
==========================================
Files 259 259
Lines 18072 18067 -5
==========================================
- Hits 16357 16352 -5
Misses 1715 1715 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| @@ -969,6 +968,8 @@ def plot_forecast_decomposition( | |||
|
|
|||
| i = 0 | |||
| for segment in segments: | |||
| skip_first_component = test_ts is None | |||
There was a problem hiding this comment.
It was a typo. We need to define the parameter skip_first_component for all segments.
There was a problem hiding this comment.
Why? Is it changing between iterations?
There was a problem hiding this comment.
It changes in line 1000 to skip only one component.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
| @@ -969,6 +968,8 @@ def plot_forecast_decomposition( | |||
|
|
|||
| i = 0 | |||
| for segment in segments: | |||
| skip_first_component = test_ts is None | |||
There was a problem hiding this comment.
Why? Is it changing between iterations?
| @@ -232,7 +232,7 @@ def _validate_target_columns(y_true: TSDataset, y_pred: TSDataset): | |||
|
|
|||
| for segment in segments: | |||
| for name, dataset in zip(("y_true", "y_pred"), (y_true, y_pred)): | |||
| if (segment, "target") not in dataset.columns: | |||
| if (segment, "target") not in dataset._df.columns: | |||
There was a problem hiding this comment.
Is this check really necessary now? I thought that now we have a guarantee that each segment has the same set of features. We could probably just check ts.features or smth like that.
|
View / edit / reply to this conversation on ReviewNB d-a-bunin commented on 2025-03-14T15:26:01Z Line #17. print(type(lower_border)) Do we need this print? |
Before submitting (must do checklist)
Proposed Changes
See #563
Closing issues
Closed #563