[WIP] Adding support for sbt-crossproject #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great I was not aware of that plugin. |
|
@mdedetrich did you actually try a js/native build? |
|
@francisdb What do you mean? |
1 similar comment
|
@francisdb What do you mean? |
I was wondering if you tried that after the merge? |
|
I can't remember, I did it so long ago. Is it currently breaking something? |
|
Not that I know, just wanted to know if somebody attempted adding support for scala native |
|
Ah right, I think there were some blockers for native (such as scalacheck) but I didn't specifically tryit (although this was a first step) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is designed to add support for sbt-crossproject. Its also designed to clean up the build a little bit. After sbt-crossproject support is merged its fairly trivial to add support for scala-native