New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BOAC-2860, Vue discourages router.push if target path matches current path #1959

Merged

pauline2k merged 1 commit into ets-berkeley-edu:master from johncrossman:BOAC-2860_callback

Oct 10, 2019

Contributor

johncrossman commented Oct 10, 2019

https://jira.ets.berkeley.edu/jira/browse/BOAC-2860

The recent upgrade of vue-router brought in its new promise API. See vuejs/vue-router#2872 The fix is a noop callback.


          BOAC-2860, Vue discourages router.push if target path matches current…

c70a609

… path

Contributor

pauline2k commented Oct 10, 2019

Whatever you say, vue-router.

pauline2k merged commit a546cc1 into ets-berkeley-edu:master

johncrossman deleted the BOAC-2860_callback branch

October 12, 2019 19:21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet