Skip to content

PEP-517 #829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 10, 2024
Merged

PEP-517 #829

merged 3 commits into from
Nov 10, 2024

Conversation

ZipFile
Copy link
Contributor

@ZipFile ZipFile commented Nov 5, 2024

By extent also PEP 518 and PEP 621.

This PR converts legacy setup.py build into PEP-517-compliant one.

Reason:

  • pip since v25 (next major release) will drop support for editable builds for non-PEP-517 projects.
  • This change makes it possible to remove generated code from the source tree (still present in source distribution, though), which lines up with latest Cython guidelines.

Questions:

  1. Unfortunately it is not possible yet to replace python setup.py build_ext --inplace since there is no equivalent functionality within python -m build. But, do we really need to do it? pip install -ve . will build extension modules either way.
  2. With this kind of build flow, moving away html code annotations is no longer needed, since they are not included by default in the sdist or wheel. Should we remove this step and just add htmls to gitignore?

@coveralls
Copy link

coveralls commented Nov 5, 2024

Coverage Status

coverage: 94.246%. remained the same
when pulling adf46bb on ZipFile:pep-517
into abf2a25 on ets-labs:master.

@ZipFile ZipFile force-pushed the pep-517 branch 3 times, most recently from 73cc89b to 2ce77e4 Compare November 5, 2024 18:19
@rmk135 rmk135 changed the base branch from master to develop November 10, 2024 05:00
@rmk135 rmk135 merged commit 494c457 into ets-labs:develop Nov 10, 2024
13 checks passed
@ZipFile ZipFile deleted the pep-517 branch November 30, 2024 09:58
@ZipFile ZipFile mentioned this pull request Dec 8, 2024
@ZipFile ZipFile added enhancement github_actions Pull requests that update GitHub Actions code labels Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants