Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setNumColumns #26

Closed
KennyGoers opened this issue Jan 6, 2014 · 3 comments
Closed

setNumColumns #26

KennyGoers opened this issue Jan 6, 2014 · 3 comments

Comments

@KennyGoers
Copy link

Any chance of getting a variation on setNumColumns?

I allow my users to change the formatting of the standard grid on the fly, setting the columns and list item style. In the current implementation this is hard coded as a layout value, any chance that is welcomed? I can do the work if it's something that is desired.

E.G. setNumColumns(int columnsPortrait, int columnsLandscape); is what would seem most consistent.

Thoughts?

@jenzz
Copy link
Contributor

jenzz commented Jan 9, 2014

+1

@denizmveli
Copy link
Contributor

Yes this can be done - see no reason not to add support for this. Essentially you want to run the same code that runs on onSizeChanged in both the SGV and ExtendableListView, when you change the column count.
I'd also add separate setters for each mColumnCountXXX.

denizmveli added a commit that referenced this issue Feb 22, 2014
Merged pull request #57 into develop - Add support for setColumnCount(int, int) - Issue #26
@denizmveli
Copy link
Contributor

setColumnCount is now in master - 1.0.4 maven release is coming soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants