Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OnScrollListener issue after updating contents #100

Merged
merged 1 commit into from
May 24, 2014

Conversation

juliendn
Copy link
Contributor

@juliendn juliendn commented May 8, 2014

AbsListView.OnScrollListener.OnScroll(...) not called after using adapter.notifyDataSetChanged.

After a look at ListView.java from the framework, I found that there is invokeOnItemScrollListener calls in layoutChildren method that miss in your implementation.

This patch fix my issue, so I share it with everyone.

@denizmveli
Copy link
Contributor

Nice find @juliendn

denizmveli added a commit that referenced this pull request May 24, 2014
OnScrollListener issue after updating contents
@denizmveli denizmveli merged commit 7d45039 into etsy:master May 24, 2014
@juliendn
Copy link
Contributor Author

Thank you!

Glad I helped to improve this cool library!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants