This repository has been archived by the owner on Dec 18, 2019. It is now read-only.
Fix status time #19
Closed
Fix status time #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 1, 2013 23:50
rename etsystatustime into statustime (including in DB which will break currently up and running installations) migration change - run the following query: alter table postmortems change etsystatustime statustime int(11) UNSIGNED NOT NULL;
This was referenced Nov 1, 2013
Closed
|
lgtm, I think we should also add a migration script so it's easier for people to update. |
mysql -p -u morgue -h localhost morgue < schemas/migrations/rename_statustime_column.sql
|
@mrtazz added migration file - is that the proper way of handling such migrations? Thoughts on communicating the change? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit fixes typos that were preventing the status time from being saved.
The second commit removes every references to etsy status time and renames them into status time. That commit is a breaking change for current up and running installation of morgue - upon pulling, the affected users will have to run
I'd be happy to update the pull request, should we decide to keep etsystatustime as a field in the DB,