feat: add custom arch support w/ env var #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've recently added a darwin_arm64 build to terraform-demux, but that can cause issues in Terraform workspaces that require older versions of Terraform - depending on the version, some don't have darwin_arm64 builds, and even the ones that do may use Terraform providers that don't have darwin_arm64 builds. In either case, the user is unable to run terraform-demux as-is, and is forced to install the amd64 version. This commit allows the user to override the architecture by specifying an environment variable, and updates the README to match. It is expected that users will set up the recommended shell alias and invoke the amd64 version of terraform when necessary, but otherwise use the native arm64 builds.
c4po
reviewed
Apr 26, 2022
|
|
||
| exitCode, err := wrapper.RunTerraform(os.Args[1:]) | ||
| if arch == "" { | ||
| arch = runtime.GOARCH |
There was a problem hiding this comment.
should we do a validation on arch?
There was a problem hiding this comment.
I thought about that! But at the end of the day if we can't find a Terraform build for your arch, it will error out, and that feels good enough to me.
c4po
approved these changes
Apr 26, 2022
PatrickDale
approved these changes
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've recently added a darwin_arm64 build to terraform-demux, but that
can cause issues in Terraform workspaces that require older versions of
Terraform - depending on the version, some don't have darwin_arm64
builds, and even the ones that do may use Terraform providers that don't
have darwin_arm64 builds. In either case, the user is unable to run
terraform-demux as-is, and is forced to install the amd64 version.
This commit allows the user to override the architecture by specifying
an environment variable, and updates the README to match. It is expected
that users will set up the recommended shell alias and invoke the amd64
version of terraform when necessary, but otherwise use the native arm64
builds.