fix: check err before using file object #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russtaylor
previously approved these changes
Jan 11, 2024
ericnorris
reviewed
Jan 11, 2024
If there is an error downloading a release archive from Hashicorp, the `zipFile` variable will be `nil` and cause a panic on the deferred call to `os.Remove` due to a nil pointer dereference. This hides the underlying error and prevents the user from knowing what the actual problem is in downloading the release archive. This change moves the order of operations around to check if there is an error returned by `downloadReleaseArchive` first before using the `zipFile` variable. In the case that there was a problem downloading the release archive from Hashicorp this function should return the originating error and not mask it with a nil pointer dereference.
ndibari-etsy
force-pushed
the
reorder_error_check_on_release_download
branch
from
f2da8db
to
eba734e
Compare
ericnorris
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change moves the order of operations around to check if there is an error returned by
downloadReleaseArchivefirst before using thezipFilevariable. In the case that there was a problem downloading the release archive from Hashicorp this function should return the originating error and not mask it with a nil pointer dereference.Context / Why are we making this change?
If there is an error downloading a release archive from Hashicorp, the
zipFilevariable will beniland cause a panic on the deferred call toos.Removedue to a nil pointer dereference. This hides the underlying error and prevents the user from knowing what the actual problem is in downloading the release archive.