feat: add sha256sum check when downloading from hashicorp #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericnorris
reviewed
Apr 14, 2022
ericnorris
reviewed
Apr 14, 2022
ericnorris
reviewed
Apr 14, 2022
ericnorris
reviewed
Apr 18, 2022
| } | ||
| sha256Sum := h.Sum(nil) | ||
|
|
||
| if checkSha256Sum != "" { |
There was a problem hiding this comment.
I'm not sure when this would be the empty string - does HashiCorp occasionally not include checksums for certain builds?
ericnorris
reviewed
Apr 18, 2022
| break | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Related to the other comment I left - should we fail if we didn't find the checksum?
There was a problem hiding this comment.
I'm worry about the string spit on double space " " may broken in some release. This should be replaced with a better regex match. I will fix it and add the error handling logic if cannot find the checksum.
ericnorris
approved these changes
Apr 18, 2022
thanks. I'll replace the find checksum logic with a regex match and add error handling logic in next PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
terraform_${version}_SHA256SUMS