-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document machine-to-machine auth options in openeo #613
Conversation
APIs/openEO/authentication.qmd
Outdated
- Likewise, the balances of processing credits are separate. | ||
It is however possible to link the balance of the client credentials account | ||
to your personal account. | ||
To enable that: contact support and provide your client id and user id. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JanssenBrm @rahmandawibowo-vito this probably needs some more work. I'm not sure what you need nowadays at the marketplace side of things to link client credential accounts with user accounts
|
7b25fb4
to
5db908b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume as a first version of the document, it is good to be merged.
Minor changed in the sentences with regards to pronoun "you" has been done
APIs/openEO/authentication.qmd
Outdated
and discusses alternative authentication methods. | ||
|
||
|
||
## Non-interactive And Machine-to-Machine Authentication with the openEO Python client library |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This too seems a bit longer title to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make it easy for people to find this I wanted to include "non-interactive" and "machine-to-machine" in the title. It also focuses heavily on python use cases, so I wanted to make that clear
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
made it bit shorter
@Pratichhya just curious: what is the background of removing "you"? is that a style guide? I also noticed you removed quite some newlines from my text, is that intentional? |
@soxofaan, the reason to update sentences having "you" or "your" as pronouns was to maintain the idea adopted in PR #533 as suggested by @HansVRP. To limit the use of "you", instead, use "user" for consistent and academic writing.
Ahh, I am extremely sorry about the newlines style. I didn't know they were intentional and thought the markdown anyway read them as a single line. I will try to update these 😅 |
Yes that's the point: from the standpoint of Markdown tools they are considered a single paragraph. |
Noted, thank you for the suggestion. I updated the changed sentences in the PR and will try to implement this in my other PRs too :) |
Are there any open issues here I have to address or other todo's to get this merged? |
Hi @soxofaan, I couldn't write earlier. Content-wise all OK from our side however to get it merged now please commit them directly to publish (not staging). With the current operations flow we follow: We are working with all stakeholders to introduce committing to staging before carrying them to public :
however we encounter several bottlenecks and still need time on them:
If that doesn't suit you, let me know if it suits you that I create a new PR and commit these directly to publish. Any other feedback / suggestions please share |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment provided
Ok I'll rebase against the publish branch However note that I expliclity chose staging because it is documented that way in the README: Lines 16 to 17 in fe8c3b0
What is also not clear:
do you really mean I should commit to the |
On README: Indeed, thank you for highlighting, I'll edit
On "commit them directly to publish (not staging)": Thanks for asking constructively, I meant the second option ("that I should work in feature branch, branching off of publish and create a pull request targetting publish"). |
I rebased this pull request targeting the |
ref: eu-cdse/openeo-cdse-infra#233