Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent changing kernel spec name in notebooks #22

Closed
soxofaan opened this issue Jul 31, 2023 · 3 comments
Closed

Prevent changing kernel spec name in notebooks #22

soxofaan opened this issue Jul 31, 2023 · 3 comments

Comments

@soxofaan
Copy link
Contributor

eec1fba added note in README to not change the kernel spec of a notebook (because that messes up the end-user experience).

I think we should enforce this better with a check script and github action

@soxofaan
Copy link
Contributor Author

Added initial check script that detected these current issues:

Checked 11 notebooks
Found 5 kernel spec issues:
sentinelhub/process_request.ipynb has unsupported kernel 'python3' (from {'display_name': 'Python 3 (ipykernel)', 'language': 'python', 'name': 'python3'})
sentinelhub/pollution.ipynb has unsupported kernel 'python3' (from {'display_name': 'Python 3 (ipykernel)', 'language': 'python', 'name': 'python3'})
sentinelhub/migration_from_scihub_guide.ipynb has unsupported kernel 'python3' (from {'display_name': 'Python 3 (ipykernel)', 'language': 'python', 'name': 'python3'})
sentinelhub/lake_ice_monitoring.ipynb has unsupported kernel 'python3' (from {'display_name': 'Python 3 (ipykernel)', 'language': 'python', 'name': 'python3'})
openeo/NDVI_Timeseries.ipynb has unsupported kernel 'python3' (from {'display_name': 'openeo_py', 'language': 'python', 'name': 'python3'})

soxofaan added a commit that referenced this issue Jul 31, 2023
@soxofaan
Copy link
Contributor Author

fixed the wrong kernel specs

and added the check as pre-commit hook

@soxofaan
Copy link
Contributor Author

added github actions workflow now too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant