Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add manpage #261

Merged
merged 3 commits into from
Apr 15, 2020
Merged

add manpage #261

merged 3 commits into from
Apr 15, 2020

Conversation

Konfekt
Copy link
Contributor

@Konfekt Konfekt commented Apr 8, 2020

addresses #81

euank
euank reviewed Apr 10, 2020
View reviewed changes
Copy link
Owner

@euank euank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good first manpage, thanks a ton for contributing it.

I left a few comments, but this overall looks like a good start

pazi.1 Outdated Show resolved Hide resolved
pazi.1 Outdated Show resolved Hide resolved
@euank
Copy link
Owner

euank commented Apr 10, 2020

Oh, there is one bikeshed; I don't think this belongs at the root of the repo, but I'm not sure where it should go.

Maybe packaging/man/pazi.1?

@Konfekt
Copy link
Contributor Author

Konfekt commented Apr 10, 2020

Thank you for reviewing! The latest commit applies your suggestions.

euank
euank approved these changes Apr 15, 2020
View reviewed changes
Copy link
Owner

@euank euank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the pr!

@euank euank merged commit 9249aab into euank:master Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@euank euank euank approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Konfekt @euank