Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: update PettingZoo version #209

Open
elliottower opened this issue Mar 28, 2023 · 3 comments
Open

Feature request: update PettingZoo version #209

elliottower opened this issue Mar 28, 2023 · 3 comments

Comments

@elliottower
Copy link

Hi, would it be possible to update this repo to use the most recent version of PettingZoo? We want to list this project in PettingZoo's third-party-environments, but we can only include environments which work with the current version.

If you need any help working out issues due to different versions feel free to ask, there were some breaking changes in version 1.2, so it requires a bit of code changes to adapt. The previous API returned done in the step() function, whereas the new one returns truncated and terminated (matching gymnasium). There is a migration guide for gymnasium explaining the changes further, the steps should be basically the same (we're working on making resources for updating old PettingZoo repositories as well): https://gymnasium.farama.org/content/migration-guide/

This issue #204 mentioned the breaking changes previously (involving dones), but hopefully I can provide a little more information and help with updating.

@eugenevinitsky
Copy link
Owner

Hey Elliott, I have no issue with that but I have 0 coding time these months and am unable to make these changes. If someone wants to open a PR doing it and ping me, I'll approve it.

@eugenevinitsky
Copy link
Owner

Sorry for the delay, bad maintainer behavior here.

@elliottower
Copy link
Author

elliottower commented May 9, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants