test: ensure swap fees are accounted #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saucepoint
commented
Mar 26, 2025
saucepoint
commented
Mar 26, 2025
saucepoint
commented
Mar 26, 2025
| // the debt will be paid by the swapper via the swap router | ||
| // TODO: can we optimize the transfer by pulling from PoolManager directly to Euler? | ||
| poolManager.take(inputCurrency, address(this), amountIn); | ||
| amountInWithoutFee = depositAssets(zeroForOne ? vault0 : vault1, amountIn) * feeMultiplier / 1e18; |
There was a problem hiding this comment.
new logic that wasnt part of the initial impl
saucepoint
commented
Mar 28, 2025
There was a problem hiding this comment.
just a forge fmt, so you can ignore the diff
hoytech
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
diff is really bad because i had to restructure the hook to avoid IR