Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Expand fail #65

Open
Emoun opened this issue Sep 29, 2021 · 2 comments · May be fixed by #66
Open

Feature Request: Expand fail #65

Emoun opened this issue Sep 29, 2021 · 2 comments · May be fixed by #66
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Emoun
Copy link
Contributor

Emoun commented Sep 29, 2021

Hi,

I want to ask whether you would consider implementing what trybuild essentially does, I.e. allowing us to check that a compilation fails with a given error message?

The reason I ask is that I'm in need of the functionality that trybuild provides, however it is missing essential features that macrotest has.
Most essential is the fact that it doesn't seem to panic upon wrong test results, which is a deal-breaker for me.
Also, features that have been implemented in macrotest are also missing (#41,#43).
Additionally, it seems silly to me that I would need to use two different crates for two functions that are so similar.

Essentially what I would need is expand_fail versions of expand and expand_without_refresh, that expects the expansion to fail and then checks the error message is as expected. If the expansion doesn't fail, or the error message is wrong, the test is a failure.

@eupn eupn added enhancement New feature or request good first issue Good for newcomers labels Sep 29, 2021
@Emoun
Copy link
Contributor Author

Emoun commented Oct 26, 2021

The trybuild crate has just rejected a feature request that is essential for duplicate (dtolnay/trybuild#108), making it all the more useful if macrotest could provide a more fully featured alternative to trybuild.

@eupn eupn self-assigned this Oct 31, 2021
@eupn
Copy link
Owner

eupn commented Oct 31, 2021

@Emoun, on it

@eupn eupn linked a pull request Nov 1, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants