pep517 is deprecated in liue of build #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocefpaf
commented
May 30, 2023
| @@ -20,12 +20,11 @@ jobs: | |||
| python-version: '3.x' | |||
| - name: Install dependencies with pip | |||
| run: | | |||
| python -m pip install --upgrade pip | |||
| pip install setuptools wheel twine pep517 | |||
There was a problem hiding this comment.
Wheel and setuptools are listed in the pyproject.toml build section and, if we "trust" pep517, we don't need to specify them here. Twine is a different beast b/c it is used to upload to PyPI but is not really a build tool. In theory all we need here is the build tool (+twine).
indeed we don't use travis anymore |
gmaze
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pep517 package is also used in the
.travis.ymlbut I guess that one is no longer used, right?