Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix argopy broken by last xarray, fsspec and erddapy releases #65

Merged
merged 46 commits into from
Nov 17, 2020
Merged

Fix argopy broken by last xarray, fsspec and erddapy releases #65

merged 46 commits into from
Nov 17, 2020

Conversation

gmaze
Copy link
Member

@gmaze gmaze commented Oct 15, 2020 •
edited
Loading

Closes #64

Closes #70

@gmaze gmaze added the bug Something isn't working label Oct 15, 2020
@gmaze gmaze self-assigned this Oct 15, 2020
@gmaze gmaze mentioned this pull request Oct 15, 2020
Closed
@dcherian dcherian mentioned this pull request Oct 15, 2020
Closed
@gmaze
Update pythontests.yml
ce39e9c 
Try to run only on mac os, to see if I can reproduce the GH failures
@gmaze
Update erddap_data.py
f44da7d
@gmaze
Update erddap_index.py
b11d691
@gmaze
Copy link
Member Author

gmaze commented Nov 11, 2020 •
edited
Loading

This branch has been merged with "erddapy" from #69

@gmaze
Copy link
Member Author

gmaze commented Nov 11, 2020

this fix works with python 3.6 and 3.7, but we have cache issue with 3.8 that make tests to fail with mac-os

when trying to fetch with caching under 3.8, we end up with a FileNotFoundError error from fsspec

try to see if this still happens with ubuntu

@gmaze gmaze mentioned this pull request Nov 11, 2020
Closed
@gmaze
Copy link
Member Author

gmaze commented Nov 11, 2020

I explain in #63 unit testing environment refactoring

@gmaze gmaze requested a review from quai20 November 11, 2020 21:28
@gmaze gmaze changed the title Fix argopy broken by xarray version 0.16.1 Fix argopy broken by last xarray and fsspec release Nov 11, 2020
@gmaze gmaze changed the title Fix argopy broken by last xarray and fsspec release Fix argopy broken by last xarray, fsspec and erddapy releases Nov 11, 2020
@gmaze gmaze mentioned this pull request Nov 16, 2020
Closed
quai20
quai20 reviewed Nov 17, 2020
View reviewed changes
requirements.txt Outdated
@@ -10,4 +10,5 @@ erddapy>=0.6
fsspec>=0.7.4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we fsspec>=0.7.4, <0.8.4 here to prevent the caching FileNotFound error ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, sounds good

@gmaze
Copy link
Member Author

gmaze commented Nov 17, 2020

ok, let's try to merge this
I will split unit testing with FREE env in a separate Github Action that will be triggered only on PR will ask for a review

@gmaze gmaze merged commit 0aea958 into master Nov 17, 2020
@gmaze gmaze deleted the xarray-016 branch December 9, 2020 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quai20 quai20 quai20 approved these changes

Assignees

@gmaze gmaze

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

erddapy update to v0.8.0 breaking argopy functionality xarray version 0.16.1 breaking argopy
2 participants
@gmaze @quai20