Critters can see staff internal shifts

[Corborax]

User Role

Attendee (Critter)

System Type

Other

Operating System

Other

OS Version

No response

Browser Details (if applicable)

No response

Steps to Reproduce

1. Have an internal role for Staff
   
2. If a Critter wants to join the join the group, they will be added as "uncomfirmed"
   

Expected Behavior

Shifts that are hidden can't be seen by members who are not confirmed members of this year.

Actual Behavior

1. Being an uncomfirmed member of a critter type enables this Critter, still being uncomfirmed, to view internal Staff shifts from the Critty Type menu / Critty type details Shift tab
   
   2.It also enables them to view the internal Staff shifts from the Shift overview
   

Feature Area

Volunteer Sign-Up

If you selected "Other", please specify

No response

Severity

Critical Problem

Error Messages

No response

Workarounds Tried

No response

Network Type

None

Anything Else?

2 changes are required:

• Hide the unconfirmed crittertypes in the shift overview / list.
• Completely block/hide the shift tab within the critter type info if the option "Hide from shift view" is set.

[Balenty]

Alternatively, these changes could be done (2nd change is differnet):

1. In the shift search, you cannot filter your Crittetypes in which you are just unconfirmed (when this hide option is set).
2. The shift tab in the Crittertype Infopage is only available when you are a full member of this Crittertype (when this hide option is set).