Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Assistant & Shares" not visible enough #85

Closed
Corborax opened this issue Jul 28, 2024 · 4 comments · Fixed by #99
Closed

"Assistant & Shares" not visible enough #85

Corborax opened this issue Jul 28, 2024 · 4 comments · Fixed by #99
Assignees
Labels
APPLICATION-Phase Issues that have to be done before the Application-Phase starts enhancement New feature or request
Milestone

Comments

@Corborax
Copy link
Member

grafik

I have received several enquiries this year about how to manage assistants and shares and where to add them.

I assume that the button is not visible enough.

Suggestion: A separate tile that manages assistants and shares.

@Corborax Corborax added the enhancement New feature or request label Jul 28, 2024
@Corborax Corborax added the APPLICATION-Phase Issues that have to be done before the Application-Phase starts label Feb 8, 2025
@Corborax Corborax added this to the EF29 milestone Feb 8, 2025
@SharkyTheWhite
Copy link
Member

Does it make sense to replace the "join" card with the assistants & shares information?
For user/dealer with active application, the join code is disallowed anyways:

if ($application?->isActive()) {
throw ValidationException::withMessages([
"code" => "You cannot join another dealership while you still have an active, uncanceled application.",
]);
}

This would allow for making the info text a bit easier to read by splitting it into registration timing vs. management of peers.
As discussed, it would make sense to add the graphical overview from the details page into the dashboard here, too.
Raw mock of suggested layout (in case of an active registration):
Image

@SharkyTheWhite SharkyTheWhite self-assigned this Feb 9, 2025
@SharkyTheWhite
Copy link
Member

Todo:

  • Keep "join another dealership" below, but no input field. Use message from validation error as text here and place cancel button besides.
  • Check if "cancel" page itself could benefit from an explanation of this (while reg open, you can reapply etc.)

@SharkyTheWhite
Copy link
Member

SharkyTheWhite commented Feb 11, 2025

Suggestion for cancellation page (not for assistant leaving page) - wording after comma matches the cancellation email text:
Image

Updated dashboard with disabled join-code field and the new better-to-find manage or invite button. Also added a badge showing what kind of registration this is, and potentially the parent dealership name:
Image

Dashboard of a share:
Image
And an assistant:
Image

@Corborax
Copy link
Member Author

Looks great to me!

The UI needs some reimagining for next year, but right now this is just awesome. :) I have no suggestions to add at this point.

Fenrikur added a commit that referenced this issue Feb 12, 2025
* feat(dashboard): improve UI for assistants and shares (#85)

* fix(style): bootstrap 4.x to 5.x migrations

---------

Co-authored-by: Fenrikur <3359222+Fenrikur@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APPLICATION-Phase Issues that have to be done before the Application-Phase starts enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants