Fix various issues with table assignment UX #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Fenrikur
commented
May 17, 2023
Fenrikur
commented
- fix isReady not ignoring canceled regs
- fix Dealers with table number but without assigned table being ready
- highlight when assigned != requested table
- fix placeholder option being removed entirely for assigned table column (reintroduces exception when selecting placeholder)
- highlight table mismatch only on Dealer
- workaround for clearing assigned table in overview (fix regression from placeholder)
- fix column labels on applications list
…mn (reintroduces exception when selecting placeholder)
julsteele
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.