Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(invite): add confirmation step to invite process #39 #48

Merged
merged 3 commits into from
Jan 31, 2024
Merged

feat(invite): add confirmation step to invite process #39 #48

merged 3 commits into from
Jan 31, 2024

Conversation

Fenrikur
Copy link
Member

No description provided.

@Fenrikur Fenrikur marked this pull request as ready for review January 31, 2024 22:02
@Fenrikur Fenrikur requested a review from julsteele January 31, 2024 22:02
julsteele
julsteele requested changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@julsteele julsteele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except for some small issues with the text and the routes, see comments. :)

resources/views/application/create.blade.php Outdated Show resolved Hide resolved
resources/views/application/edit.blade.php Outdated Show resolved Hide resolved
resources/views/application/invitees.blade.php Show resolved Hide resolved
resources/views/application/invitees.blade.php Outdated Show resolved Hide resolved
resources/views/dashboard.blade.php Show resolved Hide resolved
routes/web.php Show resolved Hide resolved
@Fenrikur Fenrikur requested a review from julsteele January 31, 2024 22:57
@Fenrikur Fenrikur merged commit ffc82c2 into main Jan 31, 2024
1 check passed
@Fenrikur Fenrikur deleted the feature/39-dealer-join-transparency branch January 31, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julsteele julsteele julsteele approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fenrikur @julsteele