Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add information that valid EF registration is required #28 #52

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

Fenrikur
Copy link
Member

@Fenrikur Fenrikur commented Feb 2, 2024

closes #28

@Fenrikur Fenrikur requested a review from julsteele February 2, 2024 01:22
Copy link
Contributor

@julsteele julsteele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as in the other PR, upper/lower case for dealership is inconsistent.

@Fenrikur
Copy link
Member Author

Fenrikur commented Feb 2, 2024

Same as in the other PR, upper/lower case for dealership is inconsistent.

Yeah, I've noticed that as well. Something we might want to take care of in a separate PR across the entire tool though, once @Corborax has told us which way he'd like it. I usually tried to use upper case where title case is appropriate or it felt like the word should receive some emphasis, but it's definitely inconsistent. ^^'

@Fenrikur Fenrikur merged commit c04ac8f into main Feb 2, 2024
1 check passed
@Fenrikur Fenrikur deleted the feature/ef-registration-required branch February 2, 2024 10:15
@Corborax
Copy link
Member

Corborax commented Feb 2, 2024

It's lowercase in text, only in headlines it's uppercase.

As a share you part in a dealership. vs. Guidelines on Dealerships

That's how it's done on the website https://www.eurofurence.org/EF28/dealersden, too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assistant with Identity ID, but no EF Reg ID
3 participants