Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand Dealers Model by Keywords #103

Closed
Metawolve opened this issue Jul 17, 2024 · 0 comments · Fixed by #112
Closed

Expand Dealers Model by Keywords #103

Metawolve opened this issue Jul 17, 2024 · 0 comments · Fixed by #112
Assignees
Labels
feature Request for an entirely new feature
Milestone

Comments

@Metawolve
Copy link
Member

The dealers den export now provides keywords in addition to the categories.

Fenrikur:
It'll basically replace the former categories or rather augment them by keywords selected within those categories.
Currently categories are provided as a simple array; so my suggestion would be adding a new field "Keywords" that contains a JSON object with categories as keys and array-typed values with the selected keywords for that category. That way we wouldn't break the old API on that (for now), but have the additional data in the response, too. (:
Example:

{
  …
  "Categories": [
    "Dogs",
    "Cats"
  ],
  "Keywords": {
    "Dogs": [
      "German Shepherd",
      "Alaskan Malamute"
    ],
    "Cats": [
      "Cheshire",
      "Jellicle"
    ]
  },
  …
}
@Metawolve Metawolve self-assigned this Jul 17, 2024
@Metawolve Metawolve added the feature Request for an entirely new feature label Jul 17, 2024
@Metawolve Metawolve added this to the EF28 (2024) milestone Jul 17, 2024
@Metawolve Metawolve linked a pull request Jul 18, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Request for an entirely new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant