Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dealers): expand model by keywords #112

Merged
merged 3 commits into from
Jul 18, 2024

Conversation

Metawolve
Copy link
Member

This pull request adds the keywords property to the dealers model.
The categories are now imported from the keys of the keywords.

Also, a few minor issues were fixed in the dealers import and dealer queries.

Example result with the new keywords:

"Categories": [
      "Commissions and Services",
      "Music and Audio",
      "Plushies"
    ],
    "Keywords": {
      "Commissions and Services": [
        "VR Integration",
        "Workshops, Classes, Tutorials"
      ],
      "Music and Audio": [
        "Music and Audio (Other)"
      ],
      "Plushies": [
        "Plushy Animals"
      ]
    },

@Metawolve Metawolve linked an issue Jul 18, 2024 that may be closed by this pull request
@Metawolve Metawolve self-assigned this Jul 18, 2024
@Metawolve Metawolve requested review from Rain336 and Fenrikur July 18, 2024 17:03
@Metawolve Metawolve added feature Request for an entirely new feature bug Things that are broken and require fixing labels Jul 18, 2024
@Metawolve Metawolve added this to the EF28 (2024) milestone Jul 18, 2024
Copy link
Member

@Fenrikur Fenrikur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Fenrikur Fenrikur changed the title 103 expand dealers model by keywords feat(dealers): expand model by keywords Jul 18, 2024
@Fenrikur Fenrikur merged commit d369d8b into main Jul 18, 2024
@Fenrikur Fenrikur deleted the 103-expand-dealers-model-by-keywords branch July 18, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Things that are broken and require fixing feature Request for an entirely new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expand Dealers Model by Keywords
2 participants