Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: artist alley allow blocking specific users as well as disabling registration #216

Conversation

maakinoh
Copy link
Contributor

@maakinoh maakinoh commented Sep 4, 2024

This PR fixes #198

Users can now be blocked from submitting new artist alley registrations.

… as disabling registration (#198)

Added Record for storing user bans.
… as disabling registration (#198)

Added api endpoint for changing the users status
… as disabling registration (#198)

Added new buttons in the backoffice for banning a user
feat(artistalley): Artist Alley allow blocking specific users as well as disabling registration (#198)

Changes in the user's status will now be logged.

BREAKING CHANGE: Added a new database table. DB update will be required
… as disabling registration (#198)

Artist alley registrations can now be enabled and disabled via the backoffice or API.

Disabling the artist alley registrations will result in a file .ArtistAlleyDisabled being created and deleted when the artist alley registrations are enabled again.

Submitting a new table application is now only possible when the artist alley is enabled
Fixed a bug in the API, where the wrong object was serialized.

Now when banning a user a reason can be specified.

Moreover, ArtistAlleyModeration.razor was cleaned up a bit
@maakinoh
Copy link
Contributor Author

maakinoh commented Sep 4, 2024

This PR will probably produce conflicts with #215.

So this PR should not be merged until #215 is merged

…specific-users-as-well-as-disabling-registration' into 198-Artist-Alley-allow-blocking-specific-users-as-well-as-disabling-registration

# Conflicts:
#	src/Eurofurence.App.Backoffice/Pages/ArtistAlleyModeration.razor
…rs-as-well-as-disabling-registration

# Conflicts:
#	src/Eurofurence.App.Backoffice/Components/ArtistAlleyApplicationDialog.razor
#	src/Eurofurence.App.Backoffice/Pages/ArtistAlleyModeration.razor
…well as disabling registration (#198)

Done some refactoring here:

+ UserStatus* was renamed to a more meaningfully UserPenalty*
+ Comments where written
+ A loading animation was added to the data grid when fetching the data
… as disabling registration (#198)

Added more documentation
…as disabling registration (#198)

Fixed broken migration and wrong API endpoint
… as disabling registration (#198)

Users can now banned from the detail dialog of an application as well
@maakinoh maakinoh marked this pull request as ready for review September 7, 2024 18:23
@maakinoh maakinoh requested a review from Fenrikur September 7, 2024 18:23
Copy link
Member

@Fenrikur Fenrikur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's currently also no way to list current penalties and potentially revoke them?
The migrations should also be compacted into a single one for a change like this.

…as disabling registration (#198)

Applied suggestions
…as disabling registration (#198)

Fixed naming of field and removed unused empty class
@Fenrikur Fenrikur merged commit 2666ef5 into main Sep 8, 2024
@Fenrikur Fenrikur deleted the 198-Artist-Alley-allow-blocking-specific-users-as-well-as-disabling-registration branch September 8, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Artist Alley allow blocking specific users as well as disabling registration
3 participants