31 migrate from mongodb to mysqlmariadb #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and included a proper AppDbContext
…g traditional layered architecture, because EF will be directly used by the services
…of repository pattern
…ntity Framework integration into the services
…f the integration of Entity Framework into the service
…ration of Entity Framework into the services
…y pattern was removed
…omparers so the lists can be parsed by entity framework
…n conversion can cause issues
…g enumeration issues with entity framework
Metawolve
added
the
enhancement
Rain336
reviewed
May 6, 2024
There was a problem hiding this comment.
Looks good! Nothing big to complain, I guess! There are a few more topics, like request cancellation using CancellationToken, but they are not really specific to the db change, since nothing in the backend currently really does that, so I don't think they have to be done right now.
src/Eurofurence.App.Domain.Model/Abstractions/IEntityRepository.cs
Outdated
Show resolved
Hide resolved
src/Eurofurence.App.Infrastructure.EntityFramework/AppDbContext.cs
Outdated
Show resolved
Hide resolved
src/Eurofurence.App.Server.Services/DependencyResolution/AutofacModule.cs
Show resolved
Hide resolved
Rain336
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I migrated the whole project, including the CLI toolbox, from the mongoDB driver to Entity Framework with MySQL/MariaDB.
During this migration, the repository pattern was removed, as Entity Framework already implements the repository pattern with the DBSets.
I also fixed up existing unit tests to work with Entity Framework.
This meant pretty substantial changes to the project, including changing some of the entities properties to actual relations, as we are now working with a relational SQL database instead of No-SQL.
I tested the core functionality of the API (creating, updating, querying and deleting different records) through Swagger and the CLI toolbox and fixed the issues I found.
There are some things I could not test properly, like the Telegram integration for example. As the changes in this issue are already pretty extensive, and as we need Entity Framework to work on some of the other open issues, I suggest that we merge these changes into main and go on from there by fixing issues we find and implementing further performance optimizations for Entity Framework in separate issues. A lot of the aspects I did not fully test yet are planned to be reworked or scrapped, like the CLI toolbox for example.