30 migrate from local disk storage to minio driven s3 #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…egistration to image which now gets uploaded to MinIO
Rain336
requested changes
Jun 9, 2024
src/Eurofurence.App.Server.Services/Abstractions/MinIO/MinIOConfiguration.cs
Show resolved
Hide resolved
Rain336
approved these changes
Jun 9, 2024
Metawolve
deleted the
30-migrate-from-local-disk-storage-to-minio-driven-s3
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, images where saved as byte arrays to the database.
I have implemented minIO using the ofifcial nuget package to save the images to a minIO bucket. This is now the case for all images, including artist allay registration images and fursuit badge images.
The minIO connection and bucket can be configured in the appsettings.json, I have added an empty example into the appsettings.sample.json.
I have tested all affected API endpoints (images, artistAllay, fursuits) using Swagger and play.min.io, I also needed to adapt the CLIToolbox a bit and tested that too.