Implement service #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jumpy-Squirrel
approved these changes
Oct 1, 2022
| type: object | ||
| properties: | ||
| payload: | ||
| type: object |
There was a problem hiding this comment.
"type: object" is not valid here according to OpenApi schema. Line should be removed.
.github/workflows/go.yml
Outdated
| - name: Set up Go | ||
| uses: actions/setup-go@v2 | ||
| with: | ||
| go-version: 1.16 |
There was a problem hiding this comment.
go version should match go.mod
| @@ -0,0 +1,7 @@ | |||
| package domain | |||
|
|
|||
| type Amount struct { | |||
There was a problem hiding this comment.
This is entirely a matter of taste, but if there is so little difference between entities and domain objects, I tend to not separate them to remove the need for mappings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the initial service scaffold. This version is not ready for production but serves as the foundation to implement the missing functionality.