Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to disable cache #287

Closed
celsoazevedo opened this issue Jun 26, 2023 · 3 comments
Closed

Option to disable cache #287

celsoazevedo opened this issue Jun 26, 2023 · 3 comments

Comments

@celsoazevedo
Copy link

I've been updating outdated chargers and adding new ones to OCM. Depending on what I am doing, sometimes I use EVMap (since their app is not the fastest) to quickly edit the entry, check if changes look okay, etc, or compare the map entries with other databases.

The "problem"? Since cache was introduced, I have to keep purging it to see changes right away.

This doesn't affect most users and it's not something that must be implemented, but it would be nice to have a way to disable caching for situations like this.

@johan12345
Copy link
Collaborator

Hmm, I'm not sure if I would want to add an option to globally disable the cache as that would negate the benefits of caching (reduced server load and better performance on slow networks).

Would a refresh button that forces the app to reload the currently viewed charger or map area from the server also be a solution?

@celsoazevedo
Copy link
Author

I guess that could work. Or if you want to hide this from most users, maybe a setting inside the hidden developer menu since this would be mostly for "debugging"?

Anything would be fine.

@celsoazevedo
Copy link
Author

celsoazevedo commented Jul 15, 2023

@johan12345 Tested this on 1.6.5 and it seems to be working. Thanks again for implementing it.

Two notes:

menu

  • The text in the "popup" menu in the charger view doesn't charge with the theme change, so dark theme = dark text.
  • For consistency sake, maybe "edit on..." should start with a capital letter?

Edit: "sounds cool" on the 3rd onboarding screen is also the only button that starts with lower case :P

johan12345 added a commit that referenced this issue Aug 1, 2023
as mentioned in comment in #287
johan12345 added a commit that referenced this issue Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants