fix picklability of sliced function array #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gertjanvanzwieten
force-pushed
the
pickleslice
branch
from
afdeec2 to
45fe876
Compare
joostvanzwieten
previously approved these changes
Oct 20, 2023
gertjanvanzwieten
force-pushed
the
pickleslice
branch
4 times, most recently
from
2c133d3 to
81152a5
Compare
This patch changed the implementation of _takeslice such that it wraps evaluable.Range directly rather than a lambda function, which caused the resulting array to not be picklable. A unit test is added to safeguard against similar mistakes in future.
gertjanvanzwieten
force-pushed
the
pickleslice
branch
from
81152a5 to
ceb262f
Compare
joostvanzwieten
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changed the implementation of
_takeslicesuch that it wrapsevaluable.Rangedirectly rather than a lambda function, which caused the resulting array to not be picklable. A unit test is added to safeguard against similar mistakes in future.