separate optimize from simplify #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gertjanvanzwieten
force-pushed
the
optimize
branch
2 times, most recently
from
862dc08 to
3ba8136
Compare
gertjanvanzwieten
force-pushed
the
optimize
branch
2 times, most recently
from
99f8a2a to
f05843b
Compare
This patch limits the deep replacement of Evaluable._optimized_for_numpy1 to the operations of _optimized_for_numpy, no longer involving _simplified. This creates a logical separation between simplify and optimized and removes overlap between the two passes. The latter (.optimized) still implies the former (.simplified), but executes it strictly in a pre-processing pass, with the subsequent optimization making only local adjustments to the simplified state. The _optimized_for_numpy methods are modified to make these adjustments in a nimble fashion rather than relying on the heavy machinery of _simplified.
gertjanvanzwieten
force-pushed
the
optimize
branch
from
f05843b to
af3d790
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR limits the deep replacement of
Evaluable._optimized_for_numpy1tothe operations of
_optimized_for_numpy, no longer involving_simplified. Thiscreates a logical separation between simplify and optimized and removes overlap
between the two passes. The latter (
.optimized) still implies the former(
.simplified), but executes it strictly in a pre-processing pass, with thesubsequent optimization making only local adjustments to the simplified state.
The
_optimized_for_numpymethods are modified to make these adjustments in animble fashion rather than relying on the heavy machinery of
_simplified.