backports #873
Merged
backports #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch replaces the _drop suffix to _op as it was originally intended.
This patch moves the type interence from util.cli to the _infer_type helper function, and uses this in log_arguments. This fixes the situation in which arguments without type annotation were not logged correctly due to failing stringly serialization.
This patch improves the parsing in _iter_stack of a function signature that contains parameters of kind VAR_POSITIONAL, by limiting itself to parameters of kind POSITIONAL_OR_KEYWORD.
This patch adds a condition to Equals.simplify to avoid that r[:,_] == r[:,_] is mistaken for r[:,_] == r[_,:], with r a Range and _ a newaxis. Though the former case of trivial equality is handled first, the bug could be triggered in case both sides of the equation are constructed in different order and therefore not identical, causing it to fall through to the second test which failed to check the insertion axes.
This patch fixes the interfaces of complex multipatch configurations such as the one now added to unittest test_topology.multipatch_misc.test_partial_ring. The patch essentially entails a large cleanup of code that went defunct after removal of edge-to-edge transformations. Additionally, the basis_std method now delegates to TrimmedTopology.basis_spline rather than TransformChainsTopology.basis_std for correct handling of edge cases.
This reverts commit 258afac.
joostvanzwieten
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.