backport of #880 #881
Merged
backport of #880 #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch introduces the topology.disjoint_union_topology helper function to deduplicate logic found in several places of the topology module, to return either an EmptyTopology if the list of topologies is empty, or the topology itself if it is the only item in the list.
This patch changes the return type of MultipatchTopology.inferfaces, from a MultipatchTopology to a DisjointUnionTopology. The reason is that the former structure added no benefits and broke the assumption that patch topologies are structured, which is now added as an assertion.
This patch changes mesh.multipatch so that patches are always of type StructuredTopology, and adds an assertion for this in the constructor.
This patch fixes the "patch{i}-{bname}" names of multipatch boundary groups,
in which the indices i were broken by commit fcff2ea.
This patch adds the unittest tests.test_topology.multipatch_L.test_groups to confirm that multipatch boundary group names are formed correctly.
gertjanvanzwieten
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.