Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Just use one connection.. #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Just use one connection.. #3

wants to merge 2 commits into from

Conversation

thinkong
Copy link

I noticed that it is currently connecting everytime it writes something to logrus.. which in my opinion it shouldn't do..

this is a pull request to make a connection when creating a new hook and using that connection for every Fire

@evalphobia
Copy link
Owner

Thanks! 😄
I could not run the test it my local environment.
Did you pass it?

@thinkong
Copy link
Author

hmm.. wonder why it's not passing the test..
I'll look into it again when I have the chance..

@evalphobia evalphobia mentioned this pull request Aug 27, 2016
Merged
@evalphobia
Copy link
Owner

@thinkong sorry for my late reply. I checked the test and modified for one connection in #8 .
I add new api New() as your intention, but I feel sorry not to merge your this PR 😢 .
Thank you for your contribution 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thinkong @evalphobia