Add FAST_AGENT_TIMING channel for instrumentation #457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add timing extraction helper function to get duration_ms from FAST_AGENT_TIMING channel - Update /history command to display turn time between Role and Chars columns - Display "-" when timing data is not available (e.g., for tool results) - Modernize type hints to use Python 3.10+ syntax (X | None instead of Optional[X]) - Update imports to use collections.abc directly for Mapping and Sequence The timing data is already captured consistently in both generate() and structured() methods in fastagent_llm.py, so this change only adds the display functionality.
- >= 80 cols: Show all columns (Role, Time, Chars, Summary) - >= 60 cols: Show Role, Time, Chars, Summary - >= 50 cols: Show Role, Chars, Summary (drop Time) - < 50 cols: Show Role, Summary (drop Time and Chars) This ensures the Summary column always has adequate space on narrower terminals by progressively hiding less critical columns.
evalstate
deleted the
claude/add-fast-agent-timing-011CUvCTGjTcbGdj3ZzvrQ21
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The timing data is already captured consistently in both generate() and structured() methods in fastagent_llm.py, so this change only adds the display functionality.