Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - building option in menu after buying a shop's entire stock #131

Open
Doronimmo opened this issue Dec 17, 2024 · 5 comments
Open

Bug - building option in menu after buying a shop's entire stock #131

Doronimmo opened this issue Dec 17, 2024 · 5 comments

Comments

@Doronimmo
Copy link
Collaborator

the shop will open after selecting the building option in menu, trying to buy from it will result in fatal error.

Doronimmo added a commit that referenced this issue Dec 22, 2024
@Doronimmo
Copy link
Collaborator Author

Possible fix: 18edb35

Doronimmo added a commit that referenced this issue Dec 22, 2024
@Doronimmo
Copy link
Collaborator Author

EDIT: not fixed :(

@evanbowman
Copy link
Owner

Ah! I see what you're saying. So you go to the shop, buy everything. Then go back to the world map, select continue building, and re-enter the shop.

@evanbowman
Copy link
Owner

e9bf291

There were a few issues. One issue was that I wasn't clearing callback hooks when entering the island edit mode. For most things, this didn't affect anything, because callbacks are generally not invoked when there isn't another island. But the shop registered an on-fadein callback hook, which was being invoked, and re-launching the shop.

Additionally, I've changed the shop script to convert the shop map location into an empty map location when you buy all of the inventory, preventing you from returning to it.

@Doronimmo Doronimmo reopened this Dec 24, 2024
@Doronimmo
Copy link
Collaborator Author

Currently, there is an enter shop sign, but no shop. The gameplay problem is solved but there are some graphical glitches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants