Add back service binding fetch instrumentation #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jahands @DaniFoldi apologies if I'm misunderstanding this MR but doesn't this specifically remove service binding fetch instrumentation? I had to revert this MR and add the functionality back in for spans to cross |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #116 , #134
What this PR solves / how to test:
When we added the fix for the JSRPC runtime change, we disabled their caller-side instrumentation completely. This PR adds back the same instrumentation that we had before. For anyone reading, we still need to figure out a non-breaking way to instrument RPC-style function calls without interfering with user code.