Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Hoe, 2.9.3 #122

Merged
merged 1 commit into from
Jan 25, 2022
Merged

Remove Hoe, 2.9.3 #122

merged 1 commit into from
Jan 25, 2022

Conversation

nateberkopec
Copy link
Collaborator

No description provided.

@eregon
Copy link
Contributor

eregon commented Jan 25, 2022

Nice, hoe always felt more like a hurdle than a help to me :)

Regarding test_all_lib_files_are_included_in_manifest you can just remove it now that a git ls-files (or a Dir.glob) is used (it was ensuring the Manifest.txt was up to date).

@nateberkopec
Copy link
Collaborator Author

Nice, hoe always felt more like a hurdle than a help to me :)

Yup, just a bit of a relic of the pre-bundler era I think.

@nateberkopec nateberkopec merged commit cc71098 into master Jan 25, 2022
@nateberkopec nateberkopec deleted the 293 branch January 25, 2022 20:03
@kbrock
Copy link
Contributor

kbrock commented Jan 27, 2022

wow. blast from the past. good job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nateberkopec @eregon @kbrock