Drop Python 3.8 support (#613)

Now EOL: https://discuss.python.org/t/python-3-8-is-now-officially-eol/66983 .
evansd · Oct 28, 2024 · 6450820 · 6450820
1 parent 946a95e
commit 6450820
Show file tree

Hide file tree

Showing 11 changed files with 6 additions and 240 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -21,7 +21,6 @@ jobs:
         - ubuntu-24.04
         - windows-2022
         python-version:
-        - '3.8'
         - '3.9'
         - '3.10'
         - '3.11'

diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -39,7 +39,7 @@ repos:
   rev: v3.17.0
   hooks:
   - id: pyupgrade
-    args: [--py38-plus]
+    args: [--py39-plus]
 - repo: https://github.com/adamchainz/django-upgrade
   rev: 1.21.0
   hooks:

diff --git a/docs/changelog.rst b/docs/changelog.rst
@@ -2,6 +2,8 @@
 Changelog
 =========
 
+* Drop Python 3.8 support.
+
 * Support Python 3.13.
 
 6.7.0 (2024-06-19)

diff --git a/pyproject.toml b/pyproject.toml
@@ -19,7 +19,7 @@ maintainers = [
 authors = [
   { name = "David Evans" },
 ]
-requires-python = ">=3.8"
+requires-python = ">=3.9"
 classifiers = [
   "Development Status :: 5 - Production/Stable",
   "Framework :: Django",
@@ -33,7 +33,6 @@ classifiers = [
   "License :: OSI Approved :: MIT License",
   "Operating System :: OS Independent",
   "Programming Language :: Python :: 3 :: Only",
-  "Programming Language :: Python :: 3.8",
   "Programming Language :: Python :: 3.9",
   "Programming Language :: Python :: 3.10",
   "Programming Language :: Python :: 3.11",

diff --git a/src/whitenoise/storage.py b/src/whitenoise/storage.py
@@ -4,9 +4,8 @@
 import os
 import re
 import textwrap
+from collections.abc import Iterator
 from typing import Any
-from typing import Iterator
-from typing import Tuple
 from typing import Union
 
 from django.conf import settings
@@ -15,7 +14,7 @@
 
 from whitenoise.compress import Compressor
 
-_PostProcessT = Iterator[Union[Tuple[str, str, bool], Tuple[str, None, RuntimeError]]]
+_PostProcessT = Iterator[Union[tuple[str, str, bool], tuple[str, None, RuntimeError]]]
 
 
 class CompressedStaticFilesStorage(StaticFilesStorage):

diff --git a/tests/requirements/compile.py b/tests/requirements/compile.py
@@ -22,46 +22,6 @@
         *sys.argv[1:],
     ]
     run = partial(subprocess.run, check=True)
-    run(
-        [
-            *common_args,
-            "--python",
-            "3.8",
-            "--output-file",
-            "py38-django32.txt",
-        ],
-        input=b"Django>=3.2a1,<3.3",
-    )
-    run(
-        [
-            *common_args,
-            "--python",
-            "3.8",
-            "--output-file",
-            "py38-django40.txt",
-        ],
-        input=b"Django>=4.0a1,<4.1",
-    )
-    run(
-        [
-            *common_args,
-            "--python",
-            "3.8",
-            "--output-file",
-            "py38-django41.txt",
-        ],
-        input=b"Django>=4.1a1,<4.2",
-    )
-    run(
-        [
-            *common_args,
-            "--python",
-            "3.8",
-            "--output-file",
-            "py38-django42.txt",
-        ],
-        input=b"Django>=4.2a1,<5.0",
-    )
     run(
         [
             *common_args,

diff --git a/tests/requirements/py38-django32.txt b/tests/requirements/py38-django32.txt
diff --git a/tests/requirements/py38-django40.txt b/tests/requirements/py38-django40.txt
diff --git a/tests/requirements/py38-django41.txt b/tests/requirements/py38-django41.txt
diff --git a/tests/requirements/py38-django42.txt b/tests/requirements/py38-django42.txt
diff --git a/tox.ini b/tox.ini
@@ -8,7 +8,6 @@ env_list =
     py311-codegen
     py310-django{51, 50, 42, 41, 40, 32}
     py39-django{42, 41, 40, 32}
-    py38-django{42, 41, 40, 32}
 
 [testenv]
 package = wheel
-Original file line number
+Diff line change
@@ Expand Up / @@ -21,7 +21,6 @@ jobs: @@
             - ubuntu-24.04
             - windows-2022
             python-version:
-            - '3.8'
             - '3.9'
             - '3.10'
             - '3.11'
@@ Expand Down @@