Should fail-fast with clear error if root path does not exist #166
Comments
javabrett
added a commit
to javabrett/httpbin
that referenced
this issue
Dec 24, 2017
…tenoise. This is a workaround for linked-issues: * https://github.com/kennethreitz/httpbin/issues/403 * https://github.com/kennethreitz/flask-common/issues/7 * evansd/whitenoise#166 Fixed postmanlabs#403.
javabrett
added a commit
to javabrett/httpbin
that referenced
this issue
Dec 24, 2017
…tenoise. This is a workaround for linked-issues: * https://github.com/kennethreitz/httpbin/issues/403 * https://github.com/kennethreitz/flask-common/issues/7 * evansd/whitenoise#166 Fixed postmanlabs#403.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Some behavioural changes can be observed when moving to Python 3.5+ when
scandirbecomes-available, as used inscantree.py.os.walk()was forgiving of a non-existent root, butos.scandir()is not.It is not clear whether Whitenoise should fail-fast if it is passed a
rootthat does not exist, but that seems reasonable. Either way the behaviour should be consistent regardless of whetherscandiris present or not./cc https://github.com/kennethreitz/httpbin/issues/403
The text was updated successfully, but these errors were encountered: