-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Django Middleware that Delays Traversal of Static Root until Requested #275
Open
thenewguy
wants to merge
11
commits into
evansd:main
Choose a base branch
from
thenewguy:lazy
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+60
−9
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
2000a9a
delayed population of files under static root until requested
thenewguy 18d8c97
logged lazy loading file
thenewguy b62df77
added LazyWhiteNoiseMiddleware to __all__
thenewguy 33c54cd
added static_root to directories so we can later map urls to paths
thenewguy 32fb4de
removed unnecessary change
thenewguy 89217dd
added LazyManifestWhiteNoiseMiddleware
thenewguy 1d05646
used WHITENOISE_KEEP_ONLY_HASHED_FILES to build known_static_urls
thenewguy d31f160
adjusted to work when manifest storage not used
thenewguy ea69116
combined LazyWhiteNoiseMiddleware and LazyManifestWhiteNoiseMiddleware
thenewguy 95160d9
fixed can_lazy_load_url() broken by copy/paste
thenewguy 626c2c6
removed LazyManifestWhiteNoiseMiddleware from __all__
thenewguy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would personally recommend implementing this feature directly into the original middleware class, and then have it toggleable by a
settings.py:WHITENOISE_LAZY
value.I'd also like to point out I agree with your idea on defaulting this to on with
ManifestStaticFilesStorage
.