Skip compression of already compressed files #347
Conversation
|
@evansd Any updates on this? |
PetrDlouhy
force-pushed
the
skip_existing_files
branch
from
c413e16
to
d2cd64c
Compare
|
@lapinvert @adamchainz I have rebased this to the current Also this would be very easily achieved when #354 is merged by simple |
|
To me it sounds a no-brainer feature to have. For projects with many static files it makes a huge difference. |
| @@ -82,14 +82,14 @@ def compress(self, path): | |||
| stat_result = os.fstat(f.fileno()) | |||
| data = f.read() | |||
| size = len(data) | |||
| if self.use_brotli: | |||
| if self.use_brotli and not os.path.isfile(f"{path}.br"): | |||
There was a problem hiding this comment.
The file names are only unique when using the CompressedManifestStaticFilesStorage backend.
When using the CompressedStaticFilesStorage backend, this would cause WhiteNoise to never re-compress a file, even if its contents have changed
There was a problem hiding this comment.
Yes, exactly. And unfortunately, in the default config, the non-MD5-hashed names are left around and can still be served... This needs some more involved consideration, and tests.
New take on #296