Handle FileNotFoundError and emit warning on broken symlink in scantree() #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Excellent work pre-commit! That is a indeed broken symlink... on purpose :) |
|
Why would we turn this into a warning when it's a clear sign of something being misconfigured? |
|
Wasn't sure about that either; silent exception handling would be just fine. |
|
What I mean was, why do anything at all? A crash seems like a good thing. Broken symlinks seem like something that the user should track down and fix. Perhaps some static assets have gone missing. I get that your server crashed but I don't think blindly ignoring the error is a good thing to do. |
|
Closing per the above. I'm not convinced Whitenoise should handle this edge case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #605.