Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jungholz Village is being created as ETC/GMT-1 #93

Closed
evansiroky opened this issue Oct 26, 2020 · 4 comments
Closed

Jungholz Village is being created as ETC/GMT-1 #93

evansiroky opened this issue Oct 26, 2020 · 4 comments
Milestone

Comments

@evansiroky
Copy link
Owner

The pene-exclave of the Jungholz Village in Austria is being created as ETC/GMT-1 as of the 2020a release.

@evansiroky evansiroky added this to the Next release milestone Oct 26, 2020
@evansiroky
Copy link
Owner Author

It appears that the underlying problem is due to the Austria OSM relation not being properly assembled into valid GeoJSON. Some 3rd party library is making the GeoJSON into a single Polygon feature with overlapping geometry. For now, I have manually edited the Austria GeoJSON input file which will be included in the input-data.zip file in the 2020d release.

I'll be leaving this issue open to try to figure out how invalid geometry was created from OSM data.

@evansiroky evansiroky modified the milestones: 2020d, Next release Nov 6, 2020
@evansiroky evansiroky reopened this Nov 6, 2020
@szjozsef
Copy link

One possible solution to solve this (instead of manually fixing the polygons) until the root case will be found for the issue is to add via union the admin 8 level polygon of Jungholz Village to the polygon of Austria, this implies 2 changes:

  • osmBoundarySources.json:
  "Jungholz, AT": {
    "name": "Jungholz",
    "admin_level": "8"
  },
  • timezones.json:
  "Europe/Vienna": [
    {
      "op": "init",
      "source": "overpass",
      "id": "Austria"
    }, {
      "op": "union",
      "source": "overpass",
      "id": "Jungholz, AT",
      "description": "For some reason this polygon get eliminated, add it back as union to Austria"
    }
  ],

@evansiroky
Copy link
Owner Author

Thanks for this @szjozsef!

@evansiroky
Copy link
Owner Author

Calling it good for now with the change provided by @szjozsef.

evansiroky added a commit that referenced this issue Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants