Skip to content

Commit

Permalink
add release notes for #871
Browse files Browse the repository at this point in the history
  • Loading branch information
evanw committed Feb 23, 2021
1 parent 096f003 commit 37d8c4f
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,10 @@
With this release, it's now possible to use e.g. `--define:import.meta.foo=123` to replace specific properties accessed off of the `import.meta` object as well as to use e.g. `--define:import.meta={\"foo\":123}` to substitute the entire `import.meta` expression with something else.
* Fix a race condition with multiple injected files ([#871](https://github.com/evanw/esbuild/issues/871))
Using multiple injected files could cause a data race that trips Go's race detector. The data race has been fixed in this release. The fix was contributed by [@Deleplace](https://github.com/Deleplace).
## 0.8.50
* Using direct `eval` now pulls in `module` and `exports`
Expand Down
4 changes: 2 additions & 2 deletions internal/bundler/bundler.go
Original file line number Diff line number Diff line change
Expand Up @@ -1079,8 +1079,8 @@ func (s *scanner) preprocessInjectedFiles() {
channel := make(chan config.InjectedFile)
s.maybeParseFile(*resolveResult, prettyPath, nil, logger.Range{}, nil, inputKindNormal, channel)

// Wait for the results in parallel
// The results slice is large enough, it is not reallocated during the computations
// Wait for the results in parallel. The results slice is large enough so
// it is not reallocated during the computations.
injectWaitGroup.Add(1)
go func(i int) {
results[i] = <-channel
Expand Down

0 comments on commit 37d8c4f

Please sign in to comment.